tdx-measure: assemble Boot0000 by hand #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
force-pushed
the
tom/boot0000
branch
from
39fa440
to
07064e8
Compare
Freax13
force-pushed
the
tom/boot0000
branch
2 times, most recently
from
a5dca35
to
f4e42a7
Compare
burgerdev
approved these changes
Sep 30, 2024
| return buffer.Bytes(), nil | ||
| } | ||
|
|
||
| // buildEfiLoadOption assembles the EFI_LOAD_OPTION passed by QEMU for boot option Boot0000. |
There was a problem hiding this comment.
How did you figure this out - is it documented somewhere or does one need to read the source to understand what's happening? Can we leave some references in case this changes with future qemu releases?
There was a problem hiding this comment.
I looked at the UEFI and PI specs and dissected the bytes manually. The constants are found in both QEMU and OVMF, so I don't think QEMU changing them is even possible without breaking older OVMFs.
There was a problem hiding this comment.
Thanks - do you think we could link the relevant parts?
There was a problem hiding this comment.
I added some spec links for the data structures.
It's always nicer to see how a value is constructed/structured rather than just hard-coding it. Now that we know how that value is derived, we can also be more confident that it won't change in the future (it's mostly comprised of constants).
Freax13
force-pushed
the
tom/boot0000
branch
from
f4e42a7
to
331a486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always nicer to see how a value is constructed/structured rather than just hard-coding it. Now that we know how that value is derived, we can also be more confident that it won't change in the future (it's mostly comprised of constants).