e2e: always sleep for 5 more seconds after resource is up #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
force-pushed
the
tom/ci-stability
branch
from
7fc6aa8
to
7aacc0a
Compare
We've seen a lot of spurious errors when connecting to various resources. It turns out if we wait just a little longer the vast majority of these errors go away. This is not clean, but it works well.
Freax13
force-pushed
the
tom/ci-stability
branch
from
7aacc0a
to
16ac01d
Compare
katexochen
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a lot of spurious errors when connecting to various resources. If we wait just a little longer the vast majority of these errors go away. This is not clean, but it works well.
I ran all e2e tests three times with these changes and only saw two failures: One of them was a timeout in the
certificate rotation and ... restarttest (probably because of the artificial delay introduced here), so I raised the timeout for that test. The other test failure was related to a DNS error while pulling the images. I didn't do anything to prevent that from happening again because I haven't seen this error occur much. All other test jobs succeeded on the first try.The downside of this change is that all e2e tests now run a bit longer, but I'd say we'd likely want to prioritize CI stability over speed.