-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caa: upgrade to v0.10.0 #1020
caa: upgrade to v0.10.0 #1020
Conversation
f80e947
to
d595884
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM mostly, but the CI SA needs some augmentation with the necessary permissions, it seems.
d595884
to
10326ef
Compare
4bc6b3f
to
f1ded3e
Compare
I needed to add the |
f1ded3e
to
a73dc7a
Compare
* wait for Kata runtime to be available * print CAA logs on error * treat unset azure_image_id as empty
Changes to the network configuration of Azure pod VMs require a NAT gateway in the subnet. Having that is desirable anyway, because default outbound access is deprecated and scheduled for removal in 2025.
a73dc7a
to
e429eeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nix changes LGTM, but I did not get to testing the change yet. If you want me to test it before, pls lmk.
Thanks, but we do have an e2e test for peer pods now, so I don't consider manual testing necessary on a PR. |
Changes to the network configuration of Azure pod VMs require a NAT gateway in the subnet. Having that is desirable anyway, because default outbound access is deprecated and scheduled for removal in 2025.
Side note: this bumps peer-pods Kata to 3.9.0, which should make it easier to integrate CAA into the node-installer.