Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caa: upgrade to v0.10.0 #1020

Merged
merged 3 commits into from
Nov 26, 2024
Merged

caa: upgrade to v0.10.0 #1020

merged 3 commits into from
Nov 26, 2024

Conversation

burgerdev
Copy link
Contributor

Changes to the network configuration of Azure pod VMs require a NAT gateway in the subnet. Having that is desirable anyway, because default outbound access is deprecated and scheduled for removal in 2025.

Side note: this bumps peer-pods Kata to 3.9.0, which should make it easier to integrate CAA into the node-installer.

@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Nov 21, 2024
@burgerdev burgerdev force-pushed the burgerdev/caa-0.10.0 branch 2 times, most recently from f80e947 to d595884 Compare November 21, 2024 13:41
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM mostly, but the CI SA needs some augmentation with the necessary permissions, it seems.

@burgerdev burgerdev force-pushed the burgerdev/caa-0.10.0 branch 2 times, most recently from 4bc6b3f to f1ded3e Compare November 25, 2024 11:11
@burgerdev
Copy link
Contributor Author

I needed to add the iptables binary to the agent-protocol-forwarder package. Not sure how that worked before... PTAL

* wait for Kata runtime to be available
* print CAA logs on error
* treat unset azure_image_id as empty
Changes to the network configuration of Azure pod VMs require a NAT
gateway in the subnet. Having that is desirable anyway, because default
outbound access is deprecated and scheduled for removal in 2025.
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nix changes LGTM, but I did not get to testing the change yet. If you want me to test it before, pls lmk.

@burgerdev
Copy link
Contributor Author

Thanks, but we do have an e2e test for peer pods now, so I don't consider manual testing necessary on a PR.

@burgerdev burgerdev merged commit 36596b8 into main Nov 26, 2024
12 checks passed
@burgerdev burgerdev deleted the burgerdev/caa-0.10.0 branch November 26, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants