WIP: Improve and simplify Deno compatibility #632
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Started doing this after discussion in #599, please let me know what you think so far, especially if it looks like I'm unknowingly about to break compatibility with something important. |
|
I should add that the reason why I've added |
TSError: src/baseConn.ts:533:9 - error TS2454: Variable 'inTypeId' is used before being assigned. src/baseConn.ts:533:29 - error TS2454: Variable 'outTypeId' is used before being assigned. src/baseConn.ts:619:9 - error TS2454: Variable 'cardinality' is used before being assigned.
denizdogan
force-pushed
the
denizdogan/denoify
branch
3 times, most recently
from
b718b86
to
2a22a5e
Compare
Not sure why this wasn't done in the first place?
This appeases `deno lint`
This helps Denoify
Use yarn run instead of npx
denizdogan
force-pushed
the
denizdogan/denoify
branch
from
2a22a5e
to
dd2591d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress – I'm aiming to remove all "custom" Deno build logic here in favor of Denoify.
packages/driver
packages/generate
???
I've taken some liberties with things like changing file naming conventions in favor of Denoify's default pattern, where
foobar.deno.tsis the Deno replacement forfoobar.ts. Previously, it's beenfoobar.node.tsandfoobar.deno.tsexplicitly.A bunch of minor cosmetic changes to appease the Deno linter.
Ended up removing
driver/.../globals.deno.tsbecause I couldn't figure out what it was for...?Explicitly import Node.js builtins, e.g.
import { Buffer } from "buffer"because Denoify needs it to do its thing. Ideally, I'd want to usenode:bufferstyle imports, Denoify actually turns that intonode:node:buffer, so I'm holding off on that.