Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(graphql): segregate graphql toolshed module #13

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Sep 27, 2023

As discussed and agreed in a Slack discussion:

[...]
something as involved as a GraphQL parser probably should be it’s own crate as well.

So, in this PR:

  • Segregate the GraphQL module into its own crate.
  • Deprecate the toolshed's graphql module in favor of the new graphql crate.

Additionally, these changes align with the GraphQL client work in #9.

@LNSD LNSD requested a review from Theodus September 27, 2023 10:43
@LNSD LNSD self-assigned this Sep 27, 2023
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not sure we even need to bother with deprecation. I think we could just remove the old graphql module immediately.

@LNSD
Copy link
Contributor Author

LNSD commented Sep 27, 2023

Looks good. Not sure we even need to bother with deprecation. I think we could just remove the old graphql module immediately.

I'd rather do it in 2 steps, so we have an intermediate stage where both modules contain the code, and we can do some tests.

@LNSD LNSD merged commit 4762f95 into main Sep 27, 2023
5 checks passed
@LNSD LNSD deleted the chore-graphql-segregate-module branch September 27, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants