-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gateway-framework): add streamingfast blockmeta service client #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
commented
Feb 14, 2024
LNSD
added
the
DO NOT MERGE (delayed release)
Delaying merge until next release cycle
label
Feb 14, 2024
LNSD
force-pushed
the
lnsd/sf-blockmeta-client
branch
from
February 14, 2024 22:28
bf24711
to
11cae61
Compare
Theodus
removed
the
DO NOT MERGE (delayed release)
Delaying merge until next release cycle
label
Feb 16, 2024
LNSD
force-pushed
the
lnsd/sf-blockmeta-client
branch
from
February 19, 2024 14:52
392ec8f
to
3648bb8
Compare
LNSD
force-pushed
the
lnsd/sf-blockmeta-client
branch
from
February 19, 2024 14:55
3648bb8
to
b0b62c6
Compare
Theodus
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Theo Butler <[email protected]>
Co-authored-by: Theo Butler <[email protected]>
Co-authored-by: Theo Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Streamingfast Blockmeta service client.
proto
file.proto-gen
feature to run thebuild.rs
based code generation. This is necessary becausetonic-build
requiresprotoc
to be installed at build time. Running code generation in the CI makes no sense, so I opted for gating the code generation with a crate feature.SfBlockmetaClient
gRPC client based on the generated files. Additionally, some integration tests covering the new client have been added.Note: To enable the client integration tests, the
IT_GATEWAY_FRAMEWORK_BLOCKMETA_URI
andIT_GATEWAY_FRAMEWORK_BLOCKMETA_AUTH_TOKEN
environment variables should be set, otherwise the tests are skipped.