Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use __all__ to expose public API #935

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Aug 16, 2023


📚 Documentation preview 📚: https://citric--935.org.readthedocs.build/en/935/

@trunk-io
Copy link

trunk-io bot commented Aug 16, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 16, 2023 02:05
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (44dceb4) 100.00% compared to head (682fe3e) 100.00%.
Report is 1 commits behind head on main.

❗ Current head 682fe3e differs from pull request most recent head 7c3ac0f. Consider uploading reports for the commit 7c3ac0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #935   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          417       420    +3     
  Branches        22        22           
=========================================
+ Hits           417       420    +3     
Files Changed Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)
src/citric/enums.py 100.00% <100.00%> (ø)
src/citric/method.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon merged commit c3c7251 into main Aug 17, 2023
29 checks passed
@edgarrmondragon edgarrmondragon deleted the refactor/use-__all__ branch August 17, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant