This makes the HTMX Component a pydantic.BaseModel #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edelvalle
force-pushed
the
components-as-pydantic-models
branch
from
6c2dd94
to
b26cf8e
Compare
mvaled
force-pushed
the
components-as-pydantic-models
branch
from
c095f08
to
fc9284e
Compare
|
I like the idea, because now when I create a base HTMX component I have to repeat its I will work on this proposal. |
mvaled
force-pushed
the
components-as-pydantic-models
branch
4 times, most recently
from
9c65cc0
to
b762c99
Compare
|
The README needs to be updated. |
mvaled
force-pushed
the
components-as-pydantic-models
branch
from
b762c99
to
78c8f86
Compare
I'm on the process of doing all of this. I went for the breaking change version, but even breaking the import which I find more dev-friendly because it won't even allow you to run the server while developing because an ImportError. This is still not ready yet. It will take some time to complete. |
mvaled
force-pushed
the
components-as-pydantic-models
branch
from
ca49d08
to
1371db2
Compare
This is a breaking change. To avoid issues I have changed the name of the base Component to HTMXComponent, so errors are harder to get to production unnoticed.
We using syntax which is not available in Python 3.6, 3.7 nor 3.9. For instance, the union operator for dicts.
mvaled
force-pushed
the
components-as-pydantic-models
branch
from
1371db2
to
e817da4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implications are:
Component.template_name->Component._template_nameComponent.__init__->Component.mountThe
__init__is now handled by pydantic