Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a function for combining two SuperLearners #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cancandan
Copy link

I hope I'm not missing something

@ecpolley
Copy link
Owner

Hi Can,

Thanks for the suggestions, but I have a few questions. What is the intended use for the subsetLearners function?

For the mergeSuperLearners, this should require some checks that both SuperLearner objects where run on the same data, and with the same cross-validation splits.

-Eric

@cancandan
Copy link
Author

Hi Eric, thanks for reply, I later realised that there's no point in removing models since SuperLearner is about doing precisely that, so function subsetLearners is meaningless. For the mergeSuperLearners I'll add the checks. Also I thought about adding some logging regarding how much time it takes for a model to train and predict. I'm new to open source development and R, so if there is any roadmap for the planned features I'd love to implement some of them, would be great for learning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants