Check error with duplicate cart #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leomp12
requested changes
Aug 23, 2023
| @@ -82,6 +82,9 @@ const prepareCart = cart => { | |||
| } else { | |||
| url = '/carts.json' | |||
| method = 'POST' | |||
| if (window.storefrontApp && window.storefrontApp.router && window.storefrontApp.router.currentRoute && window.storefrontApp.router.currentRoute.name === 'confirmation' && completed === undefined && orders === undefined) { | |||
There was a problem hiding this comment.
Aliás o router tá aí https://github.com/ecomplus/storefront/blob/475b2957e5c67a17bb2392f9aaad52209a206578/%40ecomplus/storefront-app/src/router/index.js , você pode importá-lo, window.storefrontApp.** é pra ser usado pra fora dessa lib
There was a problem hiding this comment.
Também não precisava checar esse && orders === undefined
leomp12
reviewed
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Carrinho duplicado ao criar o pedido por um usuário não cadastrado.
Quando é criado o pedido, a função
upsertCarté acionada no mesmo instante duas vezes. Em um primeiro momento, o completed e orders é undefined na rota confirmation. E ai cria um carrinho com completed false. No momento tempo, tem outroupsertCartcom completed true e order. Dai cria o carrinho completed true, ficando 2 carrinhos criados, um como "abandonado" e outro como "convertido".Como é na rota de criar o pedido de fato, não precisa criar um carrinho completado false.