Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silent should not be depend on ignoreClip #1057

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: silent should not be depend on ignoreClip #1057

merged 1 commit into from
Jan 25, 2024

Conversation

Ovilia
Copy link
Member

@Ovilia Ovilia commented Jan 25, 2024

In echarts#19197, ignoreClip is set to pictorialBar to disable clipping for labels. This causes series items not highlighting when hovering and not trigger events on clicking. I think isIgnore maybe should be checked even if not . #649 may have brought bug to this.

@Ovilia Ovilia requested a review from pissang January 25, 2024 11:18
@Ovilia Ovilia merged commit a906563 into release Jan 25, 2024
3 checks passed
@Ovilia Ovilia deleted the release-dev branch January 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants