Merge pull request #44 from eco-stake/fix-final-address-for-fallback-…

…apis Fix final address for fallback API path
eco-stake · Oct 6, 2022 · db8759d · db8759d
2 parents bdde4c2 + dc54514
commit db8759d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 13 deletions.
diff --git a/status/healthMonitor.js b/status/healthMonitor.js
@@ -38,22 +38,25 @@ function HealthMonitor() {
     const request = async () => {
       try {
         let address = new URL(url.address).href.replace(/\/$|$/, '/')
-        const response = await getLatestBlock(address, type, urlPath(type))
-        return buildUrl(type, chain, url, urlHealth, response);
+        const { path, response } = await getLatestBlock(address, type, urlPath(type))
+        return buildUrl({ type, chain, url, urlHealth, path, response });
       } catch (error) {
-        return buildUrl(type, chain, url, urlHealth, undefined, error);
+        return buildUrl({ type, chain, url, urlHealth, error });
       }
     };
     return queue.add(request, { identifier: url.address });
   }
 
   async function getLatestBlock(url, type, path){
     try {
-      return await got.get(url + path, {
-        timeout: { request: HEALTH_TIMEOUT },
-        retry: { limit: 1 },
-        agent: agent
-      });
+      return {
+        path,
+        response: await got.get(url + path, {
+          timeout: { request: HEALTH_TIMEOUT },
+          retry: { limit: 1 },
+          agent: agent
+        })
+      }
     } catch (error) {
       const fallback = fallbackPath(type)
       if (fallback && fallback !== path && error.response?.statusCode === 501) {
@@ -84,15 +87,15 @@ function HealthMonitor() {
     }
   }
 
-  function buildUrl(type, chain, url, urlHealth, response, error) {
+  function buildUrl({ type, chain, url, urlHealth, path, response, error }) {
     let timings, body, data
     let blockTime = urlHealth?.blockTime
     let blockHeight = urlHealth?.blockHeight || 0;
     let finalAddress = urlHealth?.finalAddress
     if (!error) {
       ({ timings, body } = response)
       data = JSON.parse(body);
-      const regex = new RegExp(`${urlPath(type)}/?$`)
+      const regex = new RegExp(`${path}/?$`)
       finalAddress = new URL(response.url).href.replace(regex, '').replace(/\/$|$/, '/');
       ({ error, blockTime, blockHeight } = checkHeader(type, data, chain.chainId));
     }else{

diff --git a/validators/validatorsController.js b/validators/validatorsController.js
@@ -51,9 +51,12 @@ function ValidatorsController(chainRegistry, validatorRegistry) {
 
     router.get('/chains/:chain/:validatorAddress', async (ctx, next) => {
       const chain = await chainRegistry.getChain(ctx.params.chain);
-      let validatorAddress = ctx.params.validatorAddress
-      let registryValidator = await validatorRegistry.getRegistryValidatorFromAddress(validatorAddress)
-      let validator = await validatorRegistry.getChainValidator(chain, validatorAddress, registryValidator)
+      let validator
+      if(chain){
+        let validatorAddress = ctx.params.validatorAddress
+        let registryValidator = await validatorRegistry.getRegistryValidatorFromAddress(validatorAddress)
+        validator = await validatorRegistry.getChainValidator(chain, validatorAddress, registryValidator)
+      }
       renderJson(ctx, validator && {
         name: chain.path,
         validator: validator