Rename mc::range to mc::block, better bucket scaling #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33 +/- ##
===========================================
- Coverage 61.81% 61.77% -0.04%
===========================================
Files 85 85
Lines 4376 4440 +64
Branches 486 488 +2
===========================================
+ Hits 2705 2743 +38
- Misses 1671 1697 +26 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
CI appears to be failing due to unrelated issue on the runners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that gribjump.extract scaled very poorly when using many ranges for the same field. This was due to a linearly scaling method used when inserting ranges into "buckets". Rewrote this method to use binary search.
Also extended its functionality to support more elaborate merging of overlapping ranges, which were not previously supported, or at least not correctly. To be seen if this is useful (it would be convenient for polytope if we could support overlapping ranges)