Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .clang-tidy config with minimal checks #52

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Ozaq
Copy link
Contributor

@Ozaq Ozaq commented Nov 22, 2024

The commited .clang-tidy file contains only a single check and no automated tidy runs are done.

The added check is readability-delete-null-pointer, i.e. tidy warns on superflous nullptr check before calling delete.

This commit also fixes a missing include in Report.h because this clang-tidy would otherwise report this tempalte instanciation as erroneous.

The commited .clang-tidy file contains only a single
check and no automated tidy runs are done.

The added check is readability-delete-null-pointer, i.e. tidy warns on
superflous nullptr check before calling delete.

This commit also fixes a missing include in Report.h because this
clang-tidy would otherwise report this tempalte instanciation as
erroneous.
@Ozaq Ozaq requested a review from danovaro November 22, 2024 16:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.43%. Comparing base (cf3be11) to head (0abc7a0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #52      +/-   ##
===========================================
- Coverage    64.43%   64.43%   -0.01%     
===========================================
  Files          238      238              
  Lines        13839    13838       -1     
  Branches      1334     1334              
===========================================
- Hits          8917     8916       -1     
  Misses        4922     4922              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@danovaro danovaro merged commit 81e9d57 into develop Nov 22, 2024
139 checks passed
@danovaro danovaro deleted the add-clang-tidy-config branch November 22, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants