Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tmpdir in callback and auxiliary tests #43

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ChrisspyB
Copy link
Member

@ChrisspyB ChrisspyB commented Oct 3, 2024

Fixes potential race condition when these tests are run in parallel (e.g. fdb.wipe deleting data that is being used by another test)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.15%. Comparing base (1001d61) to head (b0ef4d3).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
+ Coverage    64.07%   64.15%   +0.08%     
===========================================
  Files          238      238              
  Lines        13623    13629       +6     
  Branches      1312     1312              
===========================================
+ Hits          8729     8744      +15     
+ Misses        4894     4885       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simondsmart simondsmart merged commit 718cfc1 into develop Nov 26, 2024
133 checks passed
@danovaro danovaro deleted the hotfix/test_auxiliary_race branch November 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants