Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDB list by levels #31

Closed
wants to merge 37 commits into from
Closed

FDB list by levels #31

wants to merge 37 commits into from

Conversation

mcakircali
Copy link
Contributor

adds level var to fdb::list

new fdb-list option: --depth

major changes around ListElement

implements ctor for 1-,2-,3-level split key chains
[skip-ci]
cleanup and add missing
reworked it to behave more like an iterator
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 69.60784% with 62 lines in your changes missing coverage. Please review.

Project coverage is 63.89%. Comparing base (1122f01) to head (16b749c).

Files Patch % Lines
src/fdb5/api/helpers/ListElement.cc 38.23% 42 Missing ⚠️
src/fdb5/tools/fdb-list.cc 62.06% 11 Missing ⚠️
src/fdb5/api/RemoteFDB.cc 0.00% 6 Missing ⚠️
src/fdb5/remote/Handler.cc 0.00% 2 Missing ⚠️
src/fdb5/tools/fdb-patch.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
- Coverage    63.92%   63.89%   -0.04%     
===========================================
  Files          237      238       +1     
  Lines        13587    13611      +24     
  Branches      1322     1319       -3     
===========================================
+ Hits          8686     8697      +11     
- Misses        4901     4914      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcakircali mcakircali closed this Aug 6, 2024
@mcakircali mcakircali deleted the feature/list-iterator-level branch August 6, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants