-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feature/binary wheel #89
Conversation
Add qa to GitHub ci
Re: The name of the environment variable |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
=========================================
Coverage ? 32.90%
=========================================
Files ? 16
Lines ? 2547
Branches ? 274
=========================================
Hits ? 838
Misses ? 1697
Partials ? 12 ☔ View full report in Codecov by Sentry. |
Current names of environment variables:
|
d3593e6
to
a4f4f39
Compare
a4f4f39
to
af69397
Compare
Can I ask the status of this PR? I'm working under contract in an EU project that would greatly benefit from this PR being merged. |
Hi @jacopo-exact, it just needs a little clean-up (which I intend to do today), then we need to warn users of the upcoming change before we release it. |
dfbc993
to
fdeee41
Compare
fdeee41
to
10e199b
Compare
Not a great contribution but, as a sort of field-testing, we've been developing an application using the binary release on testpipy. It works spot-on, also in conjunction with other libraries such as |
Hi @jacopo-exact, that's great feedback - thanks! |
This Pull Request, when ready, will change the result of 'pip install eccodes' so that it will now include the ecCodes binary library automatically. This will be built for various versions of Python for Linux and MacOS (X64 and Arm64) via GitHub Actions.
By default, this bundled library will be the one used by the Python bindings. In order to use an externally-installed ecCodes binary library, set an environment variable (name of env var subject to discussion).
Current status and how to test
Example release on testpypi: https://test.pypi.org/project/eccodes/1.7.12/#files
The new wheels can be tested like this inside a virtualenv or similar:
At runtime, set this environment variable to ignore the binary wheel and use external ecCodes binary libs via findlibs:
Before
import eccodes
, set this environment variable to get a debug trace of how it is trying to find the binary libraries: