Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nnz and matrix memory size to index #45

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

sandorkertesz
Copy link
Collaborator

@sandorkertesz sandorkertesz commented Nov 23, 2024

With this PR a given matrix entry in the index file contains two additional keys:

  • nnz: number of nonzero elements in the sparse matrix
  • memory: the estimated size (in bytes) of the matrix in memory when loaded with scipy.sparse.load_npz()

This information will be used to estimate the matrix size before loading. It will be utilised in the yet to be added in memory matrix cache.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (8cb012a) to head (914f19e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #45   +/-   ##
========================================
  Coverage    92.03%   92.03%           
========================================
  Files            7        7           
  Lines          251      251           
  Branches         7        7           
========================================
  Hits           231      231           
  Misses          18       18           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sandorkertesz sandorkertesz changed the title Add nnz and marix memory size to index Add nnz and matrix memory size to index Nov 23, 2024
@sandorkertesz sandorkertesz merged commit 1ac174c into develop Nov 23, 2024
104 checks passed
@sandorkertesz sandorkertesz deleted the feature/add-nnz-to-index branch November 23, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants