Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/area extraction test #179

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

antons-it
Copy link

Area extraction unit tests that fails with -np > 2

@FussyDuck
Copy link

FussyDuck commented Mar 8, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 80.08%. Comparing base (de3896f) to head (d56b06d).

Files Patch % Lines
...as/meshgenerator/detail/StructuredMeshGenerator.cc 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
+ Coverage    80.07%   80.08%   +0.01%     
===========================================
  Files          859      860       +1     
  Lines        63682    63730      +48     
===========================================
+ Hits         50993    51039      +46     
- Misses       12689    12691       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wdeconinck
Copy link
Member

wdeconinck commented Mar 11, 2024

This test is still failing with MPI_SIZE = 120 and with grid O400.
Partition 76 coincidentally ends up with only very few points for which a mesh cannot be generated.
image

A workaround, but NOT the solution, could be choosing different MPI_SIZE (e.g. 128) or moving the area domain to include more points on partition 76 (or none at all).

@wdeconinck
Copy link
Member

This test is still failing with MPI_SIZE = 120 and with grid O400.

Other possibility is to use functionspace::PointCloud as a target. Then no mesh is attempted to be generated for partition 76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants