added config for bounding #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting this one on hold until after #9 |
|
Please update the changelog and then should be ready for review. |
|
|
|
Thanks @gmertes . Changelog is updated. |
gabrieloks
force-pushed
the
activation_functions_config
branch
from
14dbcb8
to
3bf034b
Compare
|
No changelog update? |
HCookie
reviewed
Oct 1, 2024
mchantry
reviewed
Oct 28, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
mchantry
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the implementation of activation functions in the model (ecmwf/anemoi-models#14). Here, I have just added the config entries needed for the usage of activation functions, but I have commented them so that they remain dormant. They can not be used until the feature is implemented in anemoi models.