-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor node attributes #64
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #64 +/- ##
========================================
Coverage 99.84% 99.85%
========================================
Files 23 23
Lines 1301 1350 +49
========================================
+ Hits 1299 1348 +49
Misses 2 2 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe consider adding some property typehinting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tagging me in. Looks very nice. I have some questions, but I think generally this is also good to go.
for more information, see https://pre-commit.ci
This PR introduces the
NamedNodesAttributes(nn.Module)
class, designed to enhance the management of node attributes within graph neural networks. Key features include:grid_size
attribute, indicating the total number of nodes.in_channels_src/dst
, which represents the dimensionality of the node attribute tensor.The main improvement is the ability to handle an arbitrary number of nodes. This development will facilitate extending AnemoiModelEncProcDec to other use cases, such as hierarchical models or multi-encoder/decoder.