-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Expand node attributes #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
theissenhelen
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things.
theissenhelen
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends some of the current functionality:
hidden_attributes
to define the attributes of the class that are stored in the graph during creation, and are deleted after the graph is built. These attributes are stored in their respective nodes with a prefixed "_".CutOutZarrDatasetNodes
. Now the cutout is passed directly toZarrDatasetNodes
. We extract thecutout
mask definition from the node builder into a special node attribute builder,CutOutMask
.MissingZarrVariable
andNotMissingZarrVariable
are added. They create a boolean node attribute corresponding to whether or not a particular variable is NaN in the first sample of the dataset. This will allow the user to define graphs only where ocean variables are defined.Below I show an example of how the LAM config file is changed:
Before
Now