Fix typo in CodeMiningFragment #3226
Conversation
|
Hi, can you check the status of your eclipse contributor agreement https://www.eclipse.org/legal/eca/ there also seem to be encoding changes in the pr. |
| addConfiguredBinding("CodeMinding", ''' | ||
| binder.bind(�'org.eclipse.jface.text.codemining.ICodeMiningProvider'.typeRef�.class) | ||
| .to(�codeMiningProviderClass�.class); | ||
| binder.bind(�'org.eclipse.xtext.ui.editor.reconciler.IReconcileStrategyFactory'.typeRef�.class).annotatedWith(�Names.typeRef�.named("codeMinding")) |
There was a problem hiding this comment.
hmmm wont this break clients? did you check if this is used somewhere
There was a problem hiding this comment.
@szarnekow wdyt? break and write something in release notes?
There was a problem hiding this comment.
By doing a simple text search, It's only referenced in AbstractDomainmodelUiModule#configureCodeMinding and AbstractArithmeticsUiModule#configureCodeMinding which don't seem to be used
There was a problem hiding this comment.
If we consider only this generated binding in src-gen a regeneration will fix things in the generated code.
If one had customized such binding, they should get an error if they had used @Override.
In general, I'd be in favor of this change, of course, documenting it.
There was a problem hiding this comment.
@LorenzoBettini i meant on user side. @Inject @Named("...")
There was a problem hiding this comment.
@cdietrich you're right!
However, it would be great if we could get rid of the typo ;)
There was a problem hiding this comment.
yes i assume nobody is using it. at least in xtext codebase we seem not to
awadammar
force-pushed
the
fix_typo_in_code_mining_fragment
branch
from
89a4f25
to
3b41c69
Compare
awadammar
force-pushed
the
fix_typo_in_code_mining_fragment
branch
from
3b41c69
to
dfc2175
Compare
|
So, if I understand correctly, what's left to be done is
|
|
Yes |
Introduces a minor correction in the CodeMiningFragment class.