Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix upload #3147

Merged
merged 2 commits into from
Aug 12, 2024
Merged

attempt to fix upload #3147

merged 2 commits into from
Aug 12, 2024

Conversation

cdietrich
Copy link
Member

Signed-off-by: Christian Dietrich <[email protected]>
Copy link

github-actions bot commented Aug 11, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 0e94405. ± Comparison against base commit 3952e5a.

♻️ This comment has been updated with latest results.

@cdietrich
Copy link
Member Author

or do we also have to add a run id or something?

@cdietrich
Copy link
Member Author

addd no there is a j17 and j21 build on linux

Signed-off-by: Christian Dietrich <[email protected]>
@HannesWell
Copy link
Member

This could fix the problem, but I have to check (the references) in detail when back home.

@HannesWell
Copy link
Member

I checked the existing workflows and there is either only have one job or use different names like here. So I think this fix is reasonable.
I just wonder why this didn't happen before, maybe because there were no failures?

Besides this, I think we also need #3148 to make the test-publication work.

@cdietrich cdietrich merged commit f13183d into main Aug 12, 2024
14 checks passed
@cdietrich cdietrich deleted the cd-try-to-fix-upload branch August 12, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants