Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GH workflow build in batch-mode and fail at end #3139

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

HannesWell
Copy link
Member

Without the -B Maven CLI option a lot of print-out in the build logs of Github workflows is just transfer progress.

The full-Build.sh uses the same arguments for a build in Jenkins.

@HannesWell
Copy link
Member Author

HannesWell commented Aug 10, 2024

Btw. are you interested in having test-results posted as comment in a PR as it done for all Eclipse SDK projects?
You can see it in any PR e.g. of eclipse-platform:
https://github.com/eclipse-platform/eclipse.platform/pulls

@cdietrich
Copy link
Member

In general yes

@LorenzoBettini
Copy link
Contributor

@HannesWell, this will not remove download logging from Tycho, right?
I'd like to keep that. I seem to understand it doesn't remove Tycho logging, but just in case...

concerning test results that'd be great! :)

Copy link
Contributor

@LorenzoBettini LorenzoBettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HannesWell, will you contribute the test report to another PR?

You haven't changed the Maven command in the other job build-maven-artifacts but maybe we can leave the other one as it is

@HannesWell
Copy link
Member Author

@HannesWell, will you contribute the test report to another PR?

Yes, will do that later this day.

You haven't changed the Maven command in the other job build-maven-artifacts but maybe we can leave the other one as it is

Oh indeed, I oversaw this. Will push an update later this day too.

Without the -B Maven CLI option a lot of print-out in the build logs of
Github workflows is just transfer progress.
@HannesWell
Copy link
Member Author

@HannesWell, this will not remove download logging from Tycho, right? I'd like to keep that. I seem to understand it doesn't remove Tycho logging, but just in case...

I don't know that Tycho disables any logging based on this option and I could not found anything in this regard.

You haven't changed the Maven command in the other job build-maven-artifacts but maybe we can leave the other one as it is

Just included that.

I'll create a separate PR for the test results.

@cdietrich cdietrich merged commit 65a120f into eclipse:main Aug 11, 2024
7 checks passed
@HannesWell HannesWell deleted the build-as-batch branch August 11, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants