Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum Supported Java version in Xbase and Xtend to Java 8 #3115

Merged
merged 41 commits into from
Aug 2, 2024

Conversation

cdietrich
Copy link
Member

No description provided.

szarnekow and others added 21 commits July 31, 2024 18:28
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Christian Dietrich <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
@cdietrich
Copy link
Member Author

from my pov we are good to go. wdyt @szarnekow

@cdietrich
Copy link
Member Author

am not sure if we need to do something like
org.eclipse.xtext.ui.testing.util.JavaProjectSetupUtil.makeJava7Default()

Signed-off-by: Sebastian Zarnekow <[email protected]>
@szarnekow
Copy link
Contributor

org.eclipse.xtext.ui.testing.util.JavaProjectSetupUtil.makeJava7Default()

Wow that's annoying logic

@szarnekow
Copy link
Contributor

But luckily it only cloaks a Java7 JRE as a Java6 JRE

Signed-off-by: Sebastian Zarnekow <[email protected]>
Copy link
Contributor

@LorenzoBettini LorenzoBettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdietrich @szarnekow thank you both for updating all these tests!

@cdietrich cdietrich merged commit 14e6f5d into main Aug 2, 2024
11 checks passed
@cdietrich cdietrich deleted the cd-more-experiments branch August 2, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants