Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support J21 in jenkins #3103

Closed
wants to merge 1 commit into from
Closed

support J21 in jenkins #3103

wants to merge 1 commit into from

Conversation

cdietrich
Copy link
Member

No description provided.

@cdietrich cdietrich marked this pull request as draft July 12, 2024 16:40
@cdietrich
Copy link
Member Author

Unfortunately this breaks the j11 build

@LorenzoBettini
Copy link
Contributor

mh... why is it related?
However, I see we don't have a specification for jdk 11 in the tools in Jenkinsfile

@cdietrich
Copy link
Member Author

Assume.assumeTrue("Active only on Java 21 and later", JavaRuntimeVersion.isJava21OrLater());

this guard does not seem to work

@LorenzoBettini
Copy link
Contributor

This

11:26:42  [INFO] Command line:
11:26:42  	[/opt/tools/java/temurin/jdk-21/latest/bin/java

shows that Tycho is not using Java 11 to run the tests.

@@ -26,6 +26,7 @@ pipeline {

tools {
jdk "temurin-jdk17-latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we miss the specification for jdk11

@LorenzoBettini
Copy link
Contributor

And this

11:19:26  [INFO] --- toolchains:3.1.0:toolchain (default) @ xtext-parent ---
11:19:26  [INFO] Required toolchain: jdk [ version='21' ]
11:19:26  [INFO] Found matching toolchain for type jdk: JDK[/opt/tools/java/temurin/jdk-21/latest]

shows that we either specify the wrong jdk version or it doesn't find a matching one

@LorenzoBettini
Copy link
Contributor

I'll do some experiments on top of your branch.

We should check whether the whole thing used to work before this change...

@LorenzoBettini
Copy link
Contributor

Either I miss something or from the main builds I cannot see any build with Java 11... wasn't that part of the timer-based builds (building with Java 11 and the olderst platform 4.23)?

@cdietrich
Copy link
Member Author

grafik

@cdietrich
Copy link
Member Author

maybe the daily java 11 buidls there broke too.
or it got lost.
i would have expected its still running.
but as i check fails only i have no idea

@LorenzoBettini
Copy link
Contributor

@cdietrich I found the problem, and it's my fault O:)

we enable the strict-release-jdk profile (

xtext/pom.xml

Line 423 in 839911c

<id>strict-release-jdk</id>
) but then I had added another profile that gets activated automatically when the JDK is 21 (

xtext/pom.xml

Line 449 in 839911c

<id>strict-jdk-21</id>
) this other profile forces <maven.compiler.release>21</maven.compiler.release> and so the strict-release-jdk asks Maven to use Java 21 for the toolchain, voiding our goals for that profile.

I'll have to adjust a few things with those profiles, so that they won't disturb each other.

Maybe, the easiest and cleanest thing would be to have 2 profiles strict-jdk-11 and strict-jdk-21, both activated explicitly, what do you think? This requires updating a few scripts of course.

@LorenzoBettini
Copy link
Contributor

maybe the daily java 11 buidls there broke too.
or it got lost.

the one you put in the screenshot was started manually by me

@LorenzoBettini
Copy link
Contributor

@cdietrich this should be superseded by #3105

@cdietrich cdietrich closed this Aug 3, 2024
@cdietrich cdietrich deleted the cd-j21-jenkins branch August 3, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants