Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace concatenates Strings by Text-Blocks in CompilerTests #2991

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HannesWell
Copy link
Member

This improves the readability of Strings defining the test-input and expected output. It avoids the need to explicitly add new-line characters and the need to escape double-quotes.

Currently the tests require only Java-11, but it was said that as part of #2686 Java-17 will be the required minimum.

This improves the readability of Strings defining the test-input and
expected output. It avoids the need to explicitly add new-line
characters and the need to escape double-quotes.
@@ -20,7 +20,7 @@
<attribute name="test" value="true"/>
</attributes>
</classpathentry>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11/"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am not sure if i am ok with that just for the test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR aims to the time, when Java-17 is already the required minimum. I assumed this will the case as soon Java-21 is supported? So this is actually a draft.
If you are interested in a PR that bumps the required Java-version for all bundles, I can provide one just for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants