Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect outgoing siblings for UnorderedGroup #2842

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rubenporras
Copy link
Contributor

CollectOutgoingByContainer will stop collecting the next siblings if the next to it is mandatory, because it is expected to appear in that order. Handle unordered groups as well to collect all of the outgoing siblings.

CollectOutgoingByContainer will stop collecting the next siblings if the next to it is mandatory, because it is expected to appear in that order. Handle unordered groups as well to collect all of the outgoing siblings.
@rubenporras
Copy link
Contributor Author

For #2843

@cdietrich cdietrich added this to the Release_2.34 milestone Nov 15, 2023
@szarnekow
Copy link
Contributor

@rubenporras Can you please add a test for this?

@rubenporras
Copy link
Contributor Author

Do you have a suggestion how that could be tested? I are not very experienced with how the Xtext tests are structured and what can be easily done and what not.

@szarnekow
Copy link
Contributor

szarnekow commented Jan 8, 2024

Sorry for the unreasonable delay. I just read the code here again, and I think it is reasonable. A test class to start with would be org.eclipse.xtext.parsetree.reconstr.TreeConstTest - are you still available to add a test case for unordered groups?

@cdietrich cdietrich modified the milestones: Release_2.34, Release_2.35 Feb 27, 2024
@rubenporras
Copy link
Contributor Author

Sorry also for the long delay. We have been very busy upgrading Xtext due to the release of the old Xtext generator fragments. I might have time to look at the test now.

@cdietrich cdietrich modified the milestones: Release_2.35, Release_2.36 May 23, 2024
@cdietrich cdietrich modified the milestones: Release_2.36, Release_2.37 Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants