Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upversion to 4.7.0, update snakeyaml and resolve compilation errors from get modules #2218

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Upversion to 4.7.0, update snakeyaml and resolve compilation errors from get modules #2218

merged 3 commits into from
Jul 19, 2023

Conversation

odockal
Copy link
Member

@odockal odockal commented Jul 18, 2023

Pull Request Checklist

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?
  • Is copyright with correct year in new files?
  • Is there a JavaDoc in every class with description of a class and an author(and issue if suitable)?
  • Is there a link to github project issue? (if needed)

Testing

  • Does it work?
  • Are the tests green on Jenkins? Is there a link to Jenkins build?

@odockal odockal requested a review from olkornii July 18, 2023 17:09
@odockal odockal mentioned this pull request Jul 18, 2023
Closed
@olkornii
Copy link
Contributor

testPR

@olkornii olkornii mentioned this pull request Jul 19, 2023
Closed
@olkornii
Copy link
Contributor

testPR

1 similar comment
@olkornii
Copy link
Contributor

testPR

@olkornii olkornii merged commit 344e314 into eclipse:master Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olkornii olkornii Awaiting requested review from olkornii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odockal @olkornii