Skip to content

Commit

Permalink
Merge pull request #1004 from amvanbaren/test-smoketest
Browse files Browse the repository at this point in the history
Fix method and update github action version
  • Loading branch information
amvanbaren authored Oct 2, 2024
2 parents e7603c0 + fcb209d commit cd29b73
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
timeout-minutes: 60
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
- name: Install dependencies
Expand All @@ -25,7 +25,7 @@ jobs:
- name: Run Playwright tests
working-directory: ./webui
run: yarn smoke-tests
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/smoketest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
with:
# repository: eclipse/openvsx
path: openvsx
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 18.x
- name: Install dependencies
Expand All @@ -40,6 +40,7 @@ jobs:
uses: fjogeleit/http-request-action@v1
with:
url: "https://open-vsx.org/api/version"
method: GET
- name: Check new server deployment is running
id: check_version
run: |
Expand All @@ -48,7 +49,7 @@ jobs:
if: steps.check_version.outputs.is_version
working-directory: ./openvsx/webui
run: yarn smoke-tests
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: steps.check_version.outputs.is_version
with:
name: playwright-report
Expand Down

0 comments on commit cd29b73

Please sign in to comment.