fix relevance-based ranking for java proposals to be based on rank score #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore rank score computation
BoykoAlex
approved these changes
Sep 26, 2024
|
I have not been involved in the development of the org.eclipse.lsp4e.jdt bundle, nor is it part of a stack that I am employed to maintain (as far as I know...), so I won't be reviewing here because my review wouldn't be so useful. Both your expertises it significant enough for me trust you fully if you want to merge. |
|
Marged, based in the positive review from @BoykoAlex and the comment from @mickaelistria . Thanks again to both of you! |
sebthom
reviewed
Sep 27, 2024
org.eclipse.lsp4e.jdt/src/org/eclipse/lsp4e/jdt/LSJavaCompletionProposalComputer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.