Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render markdown with commonmark instead of wikitext #1116

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Render markdown with commonmark instead of wikitext #1116

merged 1 commit into from
Sep 20, 2024

Conversation

mickaelistria
Copy link
Contributor

commonmark is the library used internally by the JDK and by JDT for markdown rendering. It's more standard and leaner than wikitext.

@mickaelistria
Render markdown with commonmark instead of wikitext
7a3b0df 
commonmark is the library used internally by the JDK and by JDT for
markdown rendering. It's more standard and leaner than wikitext.
@mickaelistria
Copy link
Contributor Author

I'm going to merge it right now as we're in the beginning of a new stream for the IDE, so that leaves some time to find and fix issues if necessary. Removing the dependency on wikitext and all in favor of the standard-ish commonmark is quite likely to bring many small benefits and doesn't seem to have any obvious pitfall at the moment.

@mickaelistria mickaelistria merged commit 68f9534 into eclipse:main Sep 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurtakov akurtakov akurtakov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickaelistria @akurtakov