Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return a Consumer<MouseEvent> if the code mining has no action. #1026

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Do not return a Consumer<MouseEvent> if the code mining has no action. #1026

merged 1 commit into from
Jun 7, 2024

Commits on Jun 6, 2024

  1. Do not return a consumer<MouseEvent> if the code mining has no action. 

    According to ICodeMining.getAction(), null should be returned if there
is no action to be executed when the mining is clicked.

When several InlayHintLabelParts are used, we cannot be sure if there is
an action or not without knowing the actual MouseEvent. However, if no
InlayHint has an action, we can be sure there is none even without
knowing the MouseEvent. For these cases, the code returns null now.
    @rubenporras
    rubenporras committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    11a78ee View commit details
    Browse the repository at this point in the history