Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced usage of Ray with Vector #21 #584

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Replaced usage of Ray with Vector #21 #584

merged 1 commit into from
Oct 6, 2024
+86 −109

Conversation

azoitl
Copy link
Contributor

@azoitl azoitl commented Oct 1, 2024

Draw2d's Ray class is deprecated. This commit removes all its usage and replaces it with the Vector class. To make migration easier two new constructors where added to Vector.

Addresses #21

@azoitl azoitl force-pushed the removeRay branch 2 times, most recently from cd72285 to 9524836 Compare October 1, 2024 22:23
ptziegler
ptziegler reviewed Oct 5, 2024
View reviewed changes
Copy link
Contributor

@ptziegler ptziegler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little bit concerned about the Vector introducing inaccuracies due to fractions, but I couldn't see anything wrong while testing. So I think it's fine to simply swap.

org.eclipse.draw2d/src/org/eclipse/draw2d/ManhattanConnectionRouter.java Outdated Show resolved Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/ManhattanConnectionRouter.java Outdated Show resolved Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/ManhattanConnectionRouter.java Outdated Show resolved Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/ManhattanConnectionRouter.java Outdated Show resolved Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/ManhattanConnectionRouter.java Outdated Show resolved Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/geometry/Vector.java Outdated Show resolved Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/ManhattanConnectionRouter.java Outdated Show resolved Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/ManhattanConnectionRouter.java Outdated Show resolved Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/ManhattanConnectionRouter.java Outdated Show resolved Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/ManhattanConnectionRouter.java Outdated Show resolved Hide resolved
@azoitl
Replaced usage of Ray with Vector eclipse#21
aacd041 
Draw2d's Ray class is deprecated. This commit removes all its usage and
replaces it with the Vector class. To make migration easier two new
constructors where added to Vector.

Addresses eclipse#21
@azoitl
Copy link
Contributor Author

azoitl commented Oct 6, 2024

It seems Eclipse Jenkins has issues accessing maven central again.

@ptziegler
Copy link
Contributor

It seems Eclipse Jenkins has issues accessing maven central again.

I think this issue lies with repo.eclipse.org, at least that's what I've noticed in the past. From what I understand, the 403 forbidden error is a fancy way of saying that the repository is down.

https://www.eclipsestatus.io/incident/422280

CI services, such as Jiro and Nexus (repo.eclipse.org) are in a degraded state, as the underlying storage device is incapable of handling peak loads. Work is underway to rectify the problem.

Hopefully, the repo was only briefly unavailable and the job will finish now.

@ptziegler ptziegler merged commit c4dc821 into eclipse:master Oct 6, 2024
9 checks passed
@ptziegler ptziegler added this to the 3.22.0 milestone Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptziegler ptziegler ptziegler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azoitl @ptziegler