Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit gathers config defaults as modules and constants in
zenoh_config::defaults
.The second commit may be more controversial. It redefines
listen.endpoints
andconnect.endpoints
as optionalModeDependentValues
. This is more accurate and allows users to explicitly set an empty list of listen endpoints and instruct Zenoh not to open any listening port. But while remaining backward compatible concerning the config file format, it slightly changes the way to access an update the conf programmatically. Thus strictly speaking it may be considered an API change.Note that
connect.endpoints
did not need to be retyped to aModeDependentValue
, but it makes things more homogeneous to have bothlisten.endpoints
andconnect.endpoints
having the same type and be accessed the same way.