Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config defaults #384

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Config defaults #384

wants to merge 1 commit into from

Conversation

OlivierHecart
Copy link
Contributor

The first commit gathers config defaults as modules and constants in zenoh_config::defaults.

The second commit may be more controversial. It redefines listen.endpoints and connect.endpoints as optional ModeDependentValues. This is more accurate and allows users to explicitly set an empty list of listen endpoints and instruct Zenoh not to open any listening port. But while remaining backward compatible concerning the config file format, it slightly changes the way to access an update the conf programmatically. Thus strictly speaking it may be considered an API change.
Note that connect.endpoints did not need to be retyped to a ModeDependentValue, but it makes things more homogeneous to have both listen.endpoints and connect.endpoints having the same type and be accessed the same way.

@Mallets Mallets marked this pull request as draft December 2, 2022 12:29
@fuzzypixelz
Copy link
Member

fuzzypixelz commented Jan 12, 2024

@OlivierHecart Please change your pull request's base branch to main (new default branch). And rebase your branch against main as it is missing a status check necessary to merge this pull request but which is only available on main.

@imstevenpmwork
Copy link
Contributor

@OlivierHecart This draft PR has been stalled for more than two years. Consider closing it if it is not longer relevant (you can always open it again whenever it is needed without losing any progress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants