fix: wait longer after z_put #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'documentation', 'new feature', 'dependencies', 'breaking-change', 'internal', 'enhancement', 'bug'} |
diogomatsubara
force-pushed
the
wait-longer-examples
branch
2 times, most recently
from
06a4e53
to
b567c3d
Compare
diogomatsubara
force-pushed
the
wait-longer-examples
branch
from
b567c3d
to
2d23187
Compare
wyfo
reviewed
Oct 14, 2024
| run: pip3 install pytest pytest-xdist | ||
| run: pip3 install pytest pytest-xdist fixtures | ||
|
|
||
| - name: Run examples check |
There was a problem hiding this comment.
Why do you need another step for examples check? Isn't it also executed as part of next pytest command?
There was a problem hiding this comment.
It looks like the pytest step doesn't auto detect the tests in examples
There was a problem hiding this comment.
I could change the name of tests/examples_check.py to tests/test_examples.py and it would be picked up by the pytest step. Should the same be done for stubs_check.py and have a single pytest call that calls all of them? Maybe having them in their own steps might be helpful for debugging. What do you think?
Mallets
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix racy behaviour in tests like: https://github.com/eclipse-zenoh/zenoh-python/actions/runs/11158739052/job/31015765836
This started as small fix to increase sleep times and ended up with a re-org of the examples test code.