Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed using namespace std #275

Closed
wants to merge 1 commit into from
Closed

removed using namespace std #275

wants to merge 1 commit into from

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Nov 7, 2023

Headers should not leak global "using namespace" statements. This causes unexpected issues in the code which include such headers. See explanation here for example https://stackoverflow.com/questions/5849457/using-namespace-in-c-headers

@milyin milyin marked this pull request as draft November 7, 2023 13:11
@milyin
Copy link
Contributor Author

milyin commented Nov 7, 2023

See #276

@cguimaraes
Copy link
Member

@milyin provided a fix in #281

@Mallets
Copy link
Member

Mallets commented Nov 28, 2023

Closing since #281 has been merged.

@Mallets Mallets closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milyin @cguimaraes @Mallets