Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zenoh cpp example compilation #274

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

jean-roland
Copy link
Contributor

@jean-roland jean-roland commented Nov 6, 2023

#268 Introduced cmake-level options to toggle the new feature tokens.

The correct default value "1" was not given to gcc which defaulted to deactivate the features, breaking compilation of examples on zenoh cpp and maybe others.

Switched from options to cache variables so the default value "1" is correctly transmitted to gcc

@p-avital p-avital merged commit 8b90376 into eclipse-zenoh:master Nov 6, 2023
44 checks passed
@jean-roland jean-roland deleted the fix_config_def_val branch November 7, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants