Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscription token config #264

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Add subscription token config #264

merged 2 commits into from
Oct 23, 2023

Conversation

jean-roland
Copy link
Contributor

Similarly to #260, this adds a compile time configuration token to (de)activate subscription capabilities.

Program memory size reduction:

  • Full feature: 127 583B
  • No subscription: 122 886B (4697B, 3.7%)

cguimaraes
cguimaraes approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@cguimaraes cguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jean-roland
Copy link
Contributor Author

Rebased the branch onto master

@Mallets Mallets merged commit 5a1e59f into eclipse-zenoh:master Oct 23, 2023
27 checks passed
@jean-roland jean-roland deleted the ft_subscription_token branch October 23, 2023 13:48
@jean-roland jean-roland mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-avital p-avital p-avital approved these changes

@cguimaraes cguimaraes cguimaraes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jean-roland @cguimaraes @p-avital @Mallets