Rename feature config tokens #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cguimaraes
approved these changes
Oct 9, 2023
Mallets
approved these changes
Oct 9, 2023
|
Proposed changes LGTM. However, CI is failing on emscripten: https://github.com/eclipse-zenoh/zenoh-pico/actions/runs/6453995045/job/17518632355?pr=258 |
|
Looks like this has broken target-dependant build config files. That's what you get for using the "whole words" rename option for config tokens, lesson learned. |
p-avital
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As prep work for additional compile-time feature config tokens, the existing ones were regrouped in config.h and given the "FEATURE" prefix/namespace.