Remove typos in constants and comments #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-avital
reviewed
Oct 4, 2023
| * Z_LINK_CAPABILITY_STREAMED: Bitmask to define and check if link is streamed. | ||
| * Z_LINK_CAPABILITY_MULTICAST: Bitmask to define and check if link is multicast. | ||
| */ | ||
| typedef enum { | ||
| Z_LINK_CAPABILITY_NONE = 0x00, // 0 | ||
| Z_LINK_CAPABILITY_RELIEABLE = 0x01, // 1 << 0 | ||
| Z_LINK_CAPABILITY_RELIABLE = 0x01, // 1 << 0 |
There was a problem hiding this comment.
@Mallets considering out-of-tree transports, isn't that technically a breaking change?
If so, we could #define Z_LINK_CAPABILITY_RELIEABLE Z_LINK_CAPABILITY_RELIABLE just to keep from a typo-related API break :)
There was a problem hiding this comment.
Is there any out-of-tree transports that we are aware of?
If not, I would accept this change.
If so, I would suggest that they contribute it back.
There was a problem hiding this comment.
All Zenoh-Pico transports we are aware of are part of the zenoh-pico repository. So I'm ok with fixing the typo as suggested by the PR.
Mallets
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the repo, I noticed some typos in both comments and constants and decided to fix them.