-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven publication: adding Maven central repository #286
Conversation
PR missing one of the required labels: {'dependencies', 'breaking-change', 'bug', 'documentation', 'internal', 'enhancement', 'new feature'} |
Should we add the |
Looks like we'll need the keyid as well when using |
@DariusIMP eclipse has updated the secrets. They also changed the variable names to conform to their internal policy. You can see the variables here: eclipse-zenoh/.eclipsefdn#18. Could you update this PR accordingly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"https://oss.sonatype.org/content/repositories/snapshots/" | ||
else | ||
"https://oss.sonatype.org/service/local/staging/deploy/maven2/" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be reversed? If it's a snapshot, publish to the staging repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok as it is, based on the documentation from https://oss.sonatype.org/content/repositories/snapshots/
build.gradle.kts
file in order to include a publication task for Maven central