Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven publication: adding Maven central repository #286

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

DariusIMP
Copy link
Member

  • Editing the build.gradle.kts file in order to include a publication task for Maven central
  • Added package signature (which is required for remote publications)
  • Edited the CI workflows for both android and jvm publications.

Copy link

github-actions bot commented Nov 5, 2024

PR missing one of the required labels: {'dependencies', 'breaking-change', 'bug', 'documentation', 'internal', 'enhancement', 'new feature'}

@DariusIMP DariusIMP added release Part of the next release internal Changes not included in the changelog labels Nov 5, 2024
.github/workflows/publish-android.yml Outdated Show resolved Hide resolved
.github/workflows/publish-android.yml Outdated Show resolved Hide resolved
.github/workflows/publish-jvm.yml Outdated Show resolved Hide resolved
@diogomatsubara
Copy link
Contributor

Should we add the -PdryRun=true option to the gradle calls and add an additional input to run it in dry run mode?
I see the snapshot input already uses the input.live_run so maybe we can change the logic there?

@diogomatsubara
Copy link
Contributor

Looks like we'll need the keyid as well when using gradle. Once the key id is available in the org secrets, I'll let you know and we can update.

@diogomatsubara
Copy link
Contributor

@DariusIMP eclipse has updated the secrets. They also changed the variable names to conform to their internal policy. You can see the variables here: eclipse-zenoh/.eclipsefdn#18. Could you update this PR accordingly?

Copy link
Contributor

@diogomatsubara diogomatsubara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"https://oss.sonatype.org/content/repositories/snapshots/"
else
"https://oss.sonatype.org/service/local/staging/deploy/maven2/"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be reversed? If it's a snapshot, publish to the staging repository?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok as it is, based on the documentation from https://oss.sonatype.org/content/repositories/snapshots/

@DariusIMP DariusIMP marked this pull request as ready for review November 13, 2024 15:11
@gabrik gabrik merged commit e1fd6a2 into eclipse-zenoh:main Nov 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog release Part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants