Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP De-plexus Tycho #4212

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP De-plexus Tycho #4212

wants to merge 1 commit into from

Conversation

cstamas
Copy link

@cstamas cstamas commented Sep 5, 2024

Applied https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup

Changes:

  • removed ol' Plexus
  • and related classes like Logger, Disposable, etc
  • using ctor injection, not field/plexus injection

Is WIP and will fail, build is OK up to OSGi compiler plugin subproject currently.

@cstamas cstamas changed the title De-plexus Tycho WIP De-plexus Tycho Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Test Results

  603 files  ± 0    4 errors  599 suites   - 4   3h 25m 52s ⏱️ - 58m 14s
  415 tests  - 15  144 ✅  - 278   7 💤 ±0   3 ❌ + 2  261 🔥 +261 
1 200 runs   - 90  425 ✅  - 842  21 💤  - 1  11 ❌ +10  743 🔥 +743 

For more details on these parsing errors, failures and errors, see this check.

Results for commit 924293d. ± Comparison against base commit 6c80860.

This pull request removes 23 and adds 8 tests. Note that renamed tests count towards both.
org.eclipse.tycho.test.eeProfile.Java11ResolutionTest ‑ testProductBuildForJava11
org.eclipse.tycho.test.eeProfile.Java17ResolutionTest ‑ testProductBuildForJava17
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ testP2ResolutionWithLowerBREEThanRequiredBundle
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ testRepositoryAggregationForJava7
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testCategoryUnitHasInclusionsVersionsExpanded
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testFeatureUnitHasOwnVersionAndInclusionsExpanded
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testIncludedExternalArtifactIsAssembled
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testIncludedReactorArtifactsAreAssembled
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testProductUnitHasOwnVersionAndInclusionsExpanded
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ testPublishedBundleIU
…
org.eclipse.tycho.test.eeProfile.Java11ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.eeProfile.Java17ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.eeProfile.Java7ResolutionTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.QualifierExpansionAndArtifactAssemblyTest ‑ Unknown test
org.eclipse.tycho.test.p2Repository.TransitiveP2RepoTest ‑ Unknown test
org.eclipse.tycho.test.packaging.ConsumerPomTest ‑ Unknown test
org.eclipse.tycho.test.product.ProductTypesTest ‑ Unknown test
org.eclipse.tycho.test.product.Tycho188P2EnabledRcpTest ‑ Unknown test

♻️ This comment has been updated with latest results.

public class DefaultRepositoryIdManager implements IRepositoryIdManager {
private final Logger logger = LoggerFactory.getLogger(getClass());

// TODO: wut? repositoryIds may CHANGE per project, as project may define new ones
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maven wants server-id to get authenticaction / proxy infos, as P2 repository has no ID we let this component "learn" what URI was used in a given id context (e.g. pom or target file), so later we can map them back to ask if maven has credentials for that ID.

As credential IDs are global one can't use different credentials/mirrors/proxy per ID and even if in theory it could be different per project this actually won't work well

@cstamas
Copy link
Author

cstamas commented Sep 23, 2024

@laeubi updated with latest main

Applied https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup

Changes:
* removed ol' Plexus
* and related classes like Logger, Disposable, etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants