Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: take over changes from node-wot PR 1210 #34

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Jul 12, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.33%. Comparing base (6d81600) to head (612d7db).

Files Patch % Lines
node/thing-model/src/tm-helpers.ts 77.77% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
- Coverage   87.14%   69.33%   -17.82%     
===========================================
  Files           6        1        -5     
  Lines         428      300      -128     
  Branches      139       79       -60     
===========================================
- Hits          373      208      -165     
- Misses         48       70       +22     
- Partials        7       22       +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner danielpeintner changed the title refactor: take over changes from https://github.com/eclipse-thingweb/… refactor: take over changes from node-wot PR 1210 Jul 12, 2024
@egekorkan
Copy link
Member

Shouldn't this be enforced at https://github.com/eclipse-thingweb/td-tools/blob/main/.eslintrc.json ?

@danielpeintner
Copy link
Member Author

IF we add this eslint rule for td-tools we might encounter some issues in the existing code.
Anyhow, I think it would be good doing so 👍

@danielpeintner
Copy link
Member Author

I checked and we do not have an .eslintrc.js. We have .eslintrc.json which serves another purpose. Shall we do it in a follow-up issue/PR because I think we will see many other changes also.

@egekorkan egekorkan merged commit e166e51 into eclipse-thingweb:main Aug 2, 2024
8 checks passed
@egekorkan egekorkan mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take over ThingModel changes from node-wot PR 1210
3 participants