Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling SCSS files with Webpack #547

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

SergioCasCeb
Copy link
Contributor

The Webpack config file has been modified to load SCSS files rather than using extra dependencies or VS extensions.

  • In production mode, it extracts CSS into separate files instead of including the styles within the JavaScript bundle. This is more suitable for production builds.
  • In development mode, it injects the styles directly into the DOM, which helps optimize the Hot Module Replacement
  • The previous CSS file created by the vs extension as well as the map file have been removed as they are not necessary anymore

The Webpack config file has been modified to load scss files.

- In Production mode it extracts CSS into separate files instead of including the styles within the JavaScript bundle. This is more suitable for production builds.
- During the development mode it injects the styles directly into the DOM, which helps optimize the Hot Module Replacement
- The previous css file created by the vs extension as well as the map file have been remove as they are not necessary anymore
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for thingweb-playground ready!

Name Link
🔨 Latest commit b69415d
🔍 Latest deploy log https://app.netlify.com/sites/thingweb-playground/deploys/658336815352490009932933
😎 Deploy Preview https://deploy-preview-547--thingweb-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- A new link to the github discussion has been added for users to provide feedback
- Fixed some bugs with the resizing of the console
- Fixed some styling bugs with the select drop down menus
egekorkan and others added 4 commits December 19, 2023 21:59
The Webpack config file has been modified to load scss files.

- In Production mode it extracts CSS into separate files instead of including the styles within the JavaScript bundle. This is more suitable for production builds.
- During the development mode it injects the styles directly into the DOM, which helps optimize the Hot Module Replacement
- The previous css file created by the vs extension as well as the map file have been remove as they are not necessary anymore
- The merging errors have been fixed
- Fixed and added missing small styling features
@egekorkan egekorkan merged commit 253b2ad into eclipse-thingweb:master Dec 20, 2023
11 of 13 checks passed
@SergioCasCeb SergioCasCeb deleted the css-mapping-sergio branch December 21, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants