Modified the default state of the console #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now instead of hiding all visualization views, the console now defaults to the validation view on its default state.
✅ Deploy Preview for thingweb-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deleted the trash icon from the console and removed any styling and functionality related to it. Note: If this were to be applied, I will highly recommend to also implement the new default state of the console, to avoid any confusing interactions with the console
…h-icon-sergio Removed trash icon from console
egekorkan
approved these changes
Dec 7, 2023
|
Could you resolve the conflict? I think it is just pushing this branch changes but I could not be sure. |
Now instead of hiding all visualization views, the console now defaults to the validation view on its default state.
…gioCasCeb/playground into console-default-state-sergio
|
I think I realized what the main issue with the conflicts with all the PR are. So I am using a vs extension to compile my sass into CSS, so it creates a css.map to do this. I think this file should be ignored since it is not necessary for the app at all and it will help avoid merge conflicts. |
- Fixed the styling errors created when rebasing the branch
|
Thanks for resolving the conflicts. I think the map file should be removed in another PR. Are you sure it is not needed though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now instead of hiding all visualization views, the console defaults to the validation view on its default state.