Added new workflow for the new web package #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thingweb-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
egekorkan
requested changes
Oct 17, 2023
egekorkan
requested changes
Oct 17, 2023
|
@SergioCasCeb I am not sure why the test is failing (timeout but why?). Any ideas? |
…Ceb/playground into playwright-ci-workflow
…Ceb/playground into playwright-ci-workflow
By utilizing the information about the duration of the new tests (which should be around 15 - 16 minutes in optimal conditions), the new timeout limit has been increased to 18 minutes to account for the duration of the tests as well as a small extra leeway to account for any other possible delays
By utilizing the information about the duration of the new tests (which should be around 15 - 16 minutes in optimal conditions), the new timeout limit has been increased to 18 minutes to account for the duration of the tests as well as a small extra leeway to account for any other possible delays
…Ceb/playground into playwright-ci-workflow
|
We need to create the server within the test file like in: https://github.com/eclipse-thingweb/playground/blob/master/packages/web/test.js#L38 |
…Ceb/playground into playwright-ci-workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new CI Workflow for testing the new web package with Playwright.