Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab deletion handle and clicking outside to close pop-ups, menus, etc. #511

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Tab deletion handle and clicking outside to close pop-ups, menus, etc. #511

merged 3 commits into from
Oct 13, 2023

Conversation

SergioCasCeb
Copy link
Contributor

@SergioCasCeb SergioCasCeb commented Oct 13, 2023 •
edited
Loading

For this PR, I have implemented the following:

  • When a user tries to close a tab/editor, a new prompt is shown to allow the user to confirm if they would actually like to close the tab. This has the purpose of avoiding closing tabs accidentally. (This should help solve issue Tab deletion handle web-new #495 )
  • The user can now close the settings menu, the save menu, and the yaml pop-up warning by clicking outside the main element.
  • Unnecessary variables and lines of code in regard to the AAS AID functionality were also removed

@SergioCasCeb
Handling the click outside the pop up elements
f6a6c1c 
Now when the users clicks outside the save menu, the settings menu and the yaml warning pop up, the elements will close respectively
@SergioCasCeb
Merge branch 'Changes-web-new' of https://github.com/SergioCasCeb/pla…
2783c6f 
…yground into Changes-web-new
@SergioCasCeb
New tab deletion handle
ac2c0fc 
Show a cancel or confirm prompt when a user tries to close a tab/editor
@netlify
Copy link

netlify bot commented Oct 13, 2023 •
edited
Loading

✅ Deploy Preview for playground-new-prreview ready!

Name Link
🔨 Latest commit ac2c0fc
🔍 Latest deploy log https://app.netlify.com/sites/playground-new-prreview/deploys/6529056b24682d00080bc07d
😎 Deploy Preview https://deploy-preview-511--playground-new-prreview.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

egekorkan
egekorkan approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice, thanks!

@egekorkan egekorkan linked an issue Oct 13, 2023 that may be closed by this pull request
Tab deletion handle web-new #495
Closed
@egekorkan egekorkan merged commit 7156bb8 into eclipse-thingweb:master Oct 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egekorkan egekorkan egekorkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab deletion handle web-new
2 participants
@SergioCasCeb @egekorkan