New changes to the example menu #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small fix in the path generation for the examples, to make sure that when the script is run only txt files are used for category descriptions and json/jsonld files for the TD and TM. Everything with a different extension should not be taken into account
…yground into Changes-web-new
A new button for users to import an example without the need to open or read the description of the example
The filter section for the examples menu has been slightly modified to simplified the filtering process as well as being more intuitive and comprehensive
|
The failing tests can be ignored for now, it is not a problem of this PR. I have tested it locally and it is fine and addresses some of the issues raised by @danielpeintner and @FadySalama about the examples page. A screenshot is below:
Something to fix is that the TD TM toggle is not showing the unselected type so it is not clear why one would want to click on it. |
The text td and tm as been added to better show the user the usability of the button
✅ Deploy Preview for playground-new-prreview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
A new icon was created and added to the examples cards to better show the usage of Thing Descriptions
|
It looks good to me now. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this pull request, I have: